[Desktop] portion of split funded tips are being processed again on browser restart

[LaurenWags]

Description

Found while testing #10153

If you have a tip which is funded via multiple sources, when you restart the browser a portion of that tip is processed/contributed again.

Steps to Reproduce

1. Launch clean profile w/ flags /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --enable-logging=stderr --vmodule=/bat-native-ledger/=6,/brave_rewards/=6 --log-level=2 --rewards=staging=true --brave-ads-staging
2. Enable Rewards
3. Claim UGP grant (30 BAT).
4. Restore the wallet, note balance (should be at least 20 BAT)
5. Tip kjozwiakstaging.github.io 50 BAT.
6. Give the tip a bit of time to process.
7. Confirmed ending wallet balance was as expected, tips panel is as expected, etc.
8. Close and relaunch.

Actual result:

The portion of the tip which was funded with the anon wallet (20 BAT) is processed again.

Expected result:

Nothing should be contributed again after restart as the tip was processed in full, successfully, prior to restart.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.12.11 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
Revision	94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @NejcZdovc @brave/legacy_qa

[GeetaSarvadnya]

Verification passed on

Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the scenarios from Fixes queue not being deleted for split one time tip brave-core#5782 (comment)

Scenario 1:

• Verified the STR mentioned above
• Verified that one-time tip is processed (20 BAT was taken from the restored anon wallet and 30 BAT from UGP, 10 BAT anon wallet funds has remained in the wallet)
• Verified that the potion of BAT funded via Restored anon wallet is not processed after the browser restart
  
  
  
  
• Verified that balance and other stats value are shown correctly in brave://rewrads-internals
• Logged [Desktop] UGP Token grants claimed is not shown in Monthly statement #10217

---

Scenario 2: (same funding sources as scenario 1, but recurring tip instead of one-time tip)

• Verified that recurring tip is processed (20 BAT was taken from the restored anon wallet and 30 BAT from UGP, 5 BAT anon wallet funds has remained in the wallet)
• Verified that the potion of BAT funded via Restored anon wallet is not processed after the browser restart.
  
  
  

• Verified that balance and other stats value are shown correctly in brave://rewrads-internals
• Encountered [Desktop] UGP Token grants claimed is not shown in Monthly statement #10217

---

Scenario 3 (same as scenario 1 but with different funding source):
(Claim UGP grant 30 BAT+ Connect KYC'd uphold with a minimum balance of 20 BAT)

• Verified that one-time tip is processed (20 BAT was taken from the KYC'd wallet and 30 BAT from UGP, 5 BAT KYC'd funds has remained in the wallet)
• Verified that the potion of BAT funded via Restored anon wallet is not processed after the browser restart.
  
  
  
  
• Verified that balance and other stats value are shown correctly in brave://rewrads-internals
• Verified that redeemed tokens 20 BAT is shown Transaction section
  
• Verified that 30 UGP grants tokens are shown (120*0.25=30 BAT)in the unblinded token table
• Verified that 50 BAT one-time tip is shown in contribution table
  

---

Scenario 4 (same as scenario 3 but with tipping a non-KYC'd, verified publisher):
(Claim UGP grant 30 BAT+ Connect KYC'd uphold with a minimum balance of 20 BAT)

• Confirmed only VG grant balance was used to tip DDG, the remaining amount (1 BAT) which would have come from Uphold was sent to pending tip as expected.
• Verified that a second entry was not added to the pending list for the Uphold portion of the last tip (1 BAT).
  
  
  
  
• Verified that balance and other stats value are shown correctly in brave://rewrads-internals
• Verified that 30 UGP grants tokens are shown (120*0.25=30 BAT)in the unblinded token table
• Verified that 30 BAT one-time tip is shown in contribution table
  

---

Verified passed with

Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified STR from description
• Confirmed on relaunch that a portion of the split tip is not processed/contributed again.

---

Verification passed on

Brave	1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision	326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS	Ubuntu 18.04 LTS

• Verified STR from description
• Confirmed on relaunch that a portion of the split tip is not processed/contributed again.