feat: remove conversion setup (#1237)

Conversion rules are now much stricter enforced than what is specified in the docs: https://ads-help.brave.com/campaign-performance/reporting/#conversion-reporting-in-brave-ads-manager We should remove conversion setup until we can adequately explain how to setup a proper URL
brave · Jun 25, 2024 · 738ece9 · 738ece9
1 parent f8b8b6d
commit 738ece9
Show file tree

Hide file tree

Showing 9 changed files with 0 additions and 237 deletions.
diff --git a/src/components/Conversion/ConversionDisplay.tsx b/src/components/Conversion/ConversionDisplay.tsx
diff --git a/src/components/Conversion/ConversionFields.tsx b/src/components/Conversion/ConversionFields.tsx
diff --git a/src/form/fragmentUtil.ts b/src/form/fragmentUtil.ts
@@ -58,11 +58,6 @@ function createAdSetFromFragment(
     })),
     price: data.price ?? "6",
     billingType: data.billingType ?? "cpm",
-    conversions: (data.conversions ?? []).map((c) => ({
-      observationWindow: c.observationWindow,
-      type: c.type,
-      urlPattern: c.urlPattern,
-    })),
     // eslint-disable-next-line lingui/no-unlocalized-strings
     name: `${data.name ? data.name : data.id.split("-")[0]} - Copy`,
     oses: (data.oses ?? []).map((o) => ({ name: o.name, code: o.code })),

diff --git a/src/user/library/index.test.ts b/src/user/library/index.test.ts
@@ -215,7 +215,6 @@ describe("new form tests", () => {
   };
 
   const adSetForm: AdSetForm = {
-    conversions: [],
     creatives: [creative, creative2],
     isNotTargeting: false,
     name: "",
@@ -253,7 +252,6 @@ describe("new form tests", () => {
               },
             ],
             "billingType": "cpm",
-            "conversions": [],
             "name": "",
             "oses": [
               {

diff --git a/src/user/library/index.ts b/src/user/library/index.ts
@@ -10,7 +10,6 @@ import {
   AdSetForm,
   Billing,
   CampaignForm,
-  Conversion,
   Creative,
   initialCreative,
   Segment,
@@ -40,7 +39,6 @@ export function transformNewForm(
     budget: form.budget,
     adSets: form.adSets.map((a) => ({
       ...transformAdSet(a, form),
-      conversions: transformConversion(a.conversions),
       ads: a.creatives
         .filter(
           (c) =>
@@ -62,18 +60,6 @@ export const transformPrice = (
     : price.toString();
 };
 
-function transformConversion(conv: Conversion[]) {
-  if (conv.length <= 0) {
-    return [];
-  }
-
-  return conv.map((c) => ({
-    observationWindow: c.observationWindow * 1.0,
-    urlPattern: c.urlPattern,
-    type: c.type,
-  }));
-}
-
 export function editCampaignValues(
   campaign: CampaignFragment,
   advertiserId: string,

diff --git a/src/user/views/adsManager/types/index.ts b/src/user/views/adsManager/types/index.ts
@@ -47,17 +47,10 @@ export type AdSetForm = {
   name: string;
   segments: Segment[];
   oses: OS[];
-  conversions: Conversion[];
   creatives: Creative[];
   isNotTargeting: boolean;
 };
 
-export type Conversion = {
-  type: string;
-  observationWindow: number;
-  urlPattern: string;
-};
-
 export type Segment = {
   code: string;
   name: string;
@@ -73,12 +66,6 @@ export type Creative = CreativeInput & {
   included: boolean;
 };
 
-export const initialConversion: Conversion = {
-  type: "",
-  urlPattern: "",
-  observationWindow: 0,
-};
-
 export const initialCreative: Creative = {
   name: "",
   advertiserId: "",
@@ -106,7 +93,6 @@ export const initialAdSet: AdSetForm = {
   name: "",
   isNotTargeting: false,
   segments: [],
-  conversions: [],
   oses: [],
   creatives: [],
 };

diff --git a/src/user/views/adsManager/views/advanced/components/adSet/AdSetFields.tsx b/src/user/views/adsManager/views/advanced/components/adSet/AdSetFields.tsx
@@ -1,5 +1,4 @@
 import { PickerFields } from "./fields/PickerFields";
-import { ConversionField } from "./fields/ConversionField";
 import { CardContainer } from "@/components/Card/CardContainer";
 import { useHistory } from "react-router-dom";
 import { FormikTextField, useIsEdit } from "@/form/FormikHelpers";
@@ -20,7 +19,6 @@ import { useLingui } from "@lingui/react";
 export function AdSetFields() {
   const { _ } = useLingui();
   const history = useHistory();
-  const { isDraft } = useIsEdit();
   const params = new URLSearchParams(history.location.search);
   const current = Number(params.get("current") ?? 0);
   const fakeCurrent = current + 1;
@@ -45,8 +43,6 @@ export function AdSetFields() {
 
       <PickerFields index={current} />
 
-      {isDraft && <ConversionField index={current} />}
-
       <AdSetAds index={current} />
     </>
   );

diff --git a/src/user/views/adsManager/views/advanced/components/adSet/fields/ConversionField.tsx b/src/user/views/adsManager/views/advanced/components/adSet/fields/ConversionField.tsx
diff --git a/src/user/views/adsManager/views/advanced/components/review/components/AdSetReview.tsx b/src/user/views/adsManager/views/advanced/components/review/components/AdSetReview.tsx
@@ -1,6 +1,5 @@
 import { AdSetForm, Creative, OS, Segment } from "../../../../../types";
 import { FormikErrors } from "formik";
-import { ConversionDisplay } from "@/components/Conversion/ConversionDisplay";
 import { ReviewField } from "./ReviewField";
 import { ReviewContainer } from "@/user/views/adsManager/views/advanced/components/review/components/ReviewContainer";
 import { CampaignFormat } from "@/graphql-client/graphql";
@@ -54,10 +53,6 @@ export function AdSetReview({ adSet, idx, errors, format }: Props) {
         value={mapToString(adSet.oses)}
         error={hasErrors ? (adSetError?.oses as string) : ""}
       />
-      <ConversionDisplay
-        conversions={adSet.conversions}
-        convErrors={adSetError?.conversions}
-      />
       <CreativeSpecificPreview
         options={included}
         useSimpleHeader