Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cbs snippets to counter video ads #84

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Add cbs snippets to counter video ads #84

merged 1 commit into from
Sep 16, 2022

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Sep 16, 2022

Given the popularity, we should block these ads. Changes in paramount/cbs. Ads are currently being shown: Based on the new snippet; thanks to Adguard https://raw.githubusercontent.com/mapx-/test/master/us.js AdguardTeam/AdguardFilters#129658

uBlockOrigin/uAssets#14849 (comment)

Still needed:

cbs.com,paramountplus.com##+js(cbs)
cbs.com,paramountplus.com##+js(cbs0)

And others:
AdguardTeam/AdguardFilters@c2fc8a1

@ryanbr ryanbr requested a review from antonok-edm September 16, 2022 08:48
@ryanbr ryanbr self-assigned this Sep 16, 2022
Copy link
Collaborator

@antonok-edm antonok-edm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @pes10k could you double check that these are safe to add as resources? I think they're alright, but good to have your input

also @ryanbr any reason these two can't be combined into the same scriptlet? If there's a try/catch around each one, it should be equivalent to injecting them separately

Copy link
Collaborator

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants