Support batched votes #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And verify behavior end-to-end!
evq
previously requested changes
May 11, 2018
evq
force-pushed
the
support-batched-votes
branch
3 times, most recently
from
117e0a3 to
d62fd2c
Compare
evq
force-pushed
the
support-batched-votes
branch
from
d62fd2c to
6464393
Compare
evq
requested changes
May 15, 2018
There was a problem hiding this comment.
this looks good, tests are passing.
my only remaining request is that you relocate the surveyor.test.js that you added and restore the original test-unit command. (the test you added is an integration test, and there are actual unit tests for bat-utils) thanks!
They pass when pointed at localhost running the branch
|
@maikelmclauflin - you ask no. the "..." is used to test the parsing and error handling, there isn't an actual value in the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #212
adds
POST /{apiV}/batch/surveyor/votingwith a payload containing an array of 1 or more{ surveyorId: '...', proof: '...' }elements, each corresponding to something created using a previous calls toGET /v2/surveyor/voting/{surveyorId}