-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate redigo to go-redis, upgrade throttled #2737
Conversation
b8273b3
to
9db4ff3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM approved with comments.
e62716a
to
73bd704
Compare
[puLL-Merge] - brave-intl/bat-go@2737 DescriptionThis PR upgrades Redis client library from Possible Issues
Security HotspotsNone significant - the changes mainly involve refactoring Redis client usage with equivalent functionality. ChangesChangesBy filename: Dockerfile:
libs/clients/coingecko/client.go:
libs/middleware/rate_limiter.go:
services/ratios/cache.go:
sequenceDiagram
participant App
participant Redis
participant Coingecko
App->>Redis: Connect (using go-redis/v9)
Note over Redis: New connection pool managed by go-redis
App->>Redis: Check cache for market data
alt Cache Miss
App->>Coingecko: Fetch latest data
Coingecko-->>App: Return market data
App->>Redis: Store in cache
else Cache Hit
Redis-->>App: Return cached data
end
|
Summary
This PR replaces our outdated
redigo
dependency withgo-redis
.Type of Change
Tested Environments
Before Requesting Review