Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update x/net to v0.23.0 #2703

Merged
merged 3 commits into from
Nov 6, 2024
Merged

chore: update x/net to v0.23.0 #2703

merged 3 commits into from
Nov 6, 2024

Conversation

pavelbrm
Copy link
Contributor

@pavelbrm pavelbrm commented Nov 5, 2024

Summary

Subj.

Fixes https://github.com/brave-intl/bat-go/security/dependabot/119.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/120.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/121.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/122.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/123.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/124.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@pavelbrm pavelbrm self-assigned this Nov 5, 2024
@pavelbrm pavelbrm requested a review from clD11 November 5, 2024 07:22
Copy link

github-actions bot commented Nov 6, 2024

[puLL-Merge] - brave-intl/bat-go@2703

Description

This pull request updates Go dependencies across multiple modules in the project, with a focus on upgrading crypto-related packages and setting the GOTOOLCHAIN environment variable to "local". The changes aim to improve security and ensure consistent toolchain usage across different environments.

Changes

Changes

  1. .github/workflows/ci.yml:

    • Added GOTOOLCHAIN: local to the environment variables.
  2. Dockerfile:

    • Added GOTOOLCHAIN=local to the Go build command.
  3. Makefile:

    • Added GOTOOLCHAIN=local to multiple Go build commands.
  4. Go module files (go.mod and go.sum):

    • Updated in multiple directories: cmd, libs, main, services, tools, and nitro-shim/tools/gvproxy.
    • Key updates include:
      • golang.org/x/crypto upgraded from v0.17.0 to v0.21.0
      • golang.org/x/net upgraded from v0.17.0 to v0.23.0
      • golang.org/x/sys upgraded from v0.15.0 to v0.18.0
      • golang.org/x/term upgraded from v0.15.0 to v0.18.0
  5. Docker Compose files:

    • Added GOTOOLCHAIN=local to the environment variables in multiple files:
      • docker-compose.dev-refresh.yml
      • docker-compose.yml
      • services/rewards/docker-compose.yml
      • services/skus/docker-compose.payment-refresh.yml
      • services/skus/docker-compose.yml
      • services/wallet/docker-compose.yml
  6. tools/Dockerfile:

    • Added GOTOOLCHAIN=local to the Go build command.

These changes ensure that the project uses a consistent Go toolchain across different environments and updates important security-related packages to their latest versions.

Security Hotspots

The upgrade of golang.org/x/crypto to v0.21.0 is a significant security improvement, as it likely includes important security fixes and enhancements. It's important to test thoroughly after this upgrade to ensure all cryptographic operations still function correctly.

@pavelbrm pavelbrm merged commit e7cb7e3 into master Nov 6, 2024
13 checks passed
@pavelbrm pavelbrm deleted the update-dep-x branch November 6, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants