Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update hashicorp vault to v1.18.1 #2662

Closed
wants to merge 3 commits into from
Closed

Conversation

pavelbrm
Copy link
Contributor

@pavelbrm pavelbrm commented Oct 1, 2024

Summary

Fixes https://github.com/brave-intl/bat-go/security/dependabot/143.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/144.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/145.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/146.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/147.
Fixes https://github.com/brave-intl/bat-go/security/dependabot/148.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@pavelbrm pavelbrm self-assigned this Oct 1, 2024
@pavelbrm pavelbrm marked this pull request as draft October 1, 2024 07:48
@pavelbrm pavelbrm changed the title chore: update hashicorp vault to v1.17.6 chore: update hashicorp vault to v1.18.1 Nov 5, 2024
@@ -10,234 +12,530 @@ replace github.com/brave-intl/bat-go/libs => ../libs

replace github.com/brave-intl/bat-go/tools => ../tools

replace github.com/pires/go-proxyproto v1.0.0 => github.com/pires/go-proxyproto v0.8.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Here and below, this is necessary because one of the Hashicorp's dependencies listed github.com/pires/go-proxyproto v1.0.0 in their go.mod file, but this version never existed. The latest available version is v0.8.0. So this replace directive makes it work.

@pavelbrm pavelbrm mentioned this pull request Nov 5, 2024
18 tasks
@pavelbrm pavelbrm marked this pull request as ready for review November 5, 2024 07:17
@pavelbrm pavelbrm requested a review from clD11 November 5, 2024 07:22
@pavelbrm
Copy link
Contributor Author

pavelbrm commented Nov 7, 2024

Superseded by #2707.

@pavelbrm pavelbrm closed this Nov 7, 2024
@pavelbrm pavelbrm deleted the update-vault branch November 7, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants