Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index_key is required when lifecycle.drop = true #67

Closed
brantburnett opened this issue Aug 10, 2021 · 0 comments · Fixed by #69
Closed

index_key is required when lifecycle.drop = true #67

brantburnett opened this issue Aug 10, 2021 · 0 comments · Fixed by #69

Comments

@brantburnett
Copy link
Owner

Triggering YAML:

index_key:
- type
- id
name: example
num_replica: 0
---
index_key:
- type
- name
name: example2
num_replica: 0
---
lifecycle:
  drop: true
name: example3

Error message:

Error: index_key must include at least one key in example
brantburnett added a commit that referenced this issue Aug 10, 2021
@brantburnett
Loosen validation requirements for dropped indices
79bb7c6 
Motivation
----------
We shouldn't require the index definition details for indices being
dropped.

Modifications
-------------
Accept dropped indices with only a name attribute.

Update to NPM lockfile v2.

Improve some local test scripts.

Fixes #67
@brantburnett brantburnett mentioned this issue Aug 10, 2021
Merged
brantburnett added a commit that referenced this issue Aug 10, 2021
@brantburnett
Loosen validation requirements for dropped indices (#69)
42691aa 
Motivation
----------
We shouldn't require the index definition details for indices being
dropped.

Modifications
-------------
Accept dropped indices with only a name attribute.

Update to NPM lockfile v2.

Improve some local test scripts.

Fixes #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Loosen validation requirements for dropped indices brantburnett/couchbase-index-manager
1 participant
@brantburnett