Skip to content

Conversation

rcassani
Copy link

@rcassani rcassani commented Dec 15, 2021

  1. Add a check for the required Matlab toolboxes.

  2. Let Brainstorm to handle FieldTrip defaults

  3. Bugfix at creating paths in Unix-like OS

@ftadel
Copy link
Collaborator

ftadel commented Dec 15, 2021

@branelab
You should not add or remove folders from the FieldTrip path, you should let Brainstorm and/or FieldTrip manage their own paths.
When installing FieldTrip, one should NOT add all the subfolders to the Matlab path. Only the top folder of FieldTrip can be added to the path (exactly like Brainstorm). Then FieldTrip adds to the path the subfolders that are needed only, depending on the Matlab version and the additional toolboxes installed on the computer.

@rcassani
You may remove all these lines dealing with the FieldTrip path management: these folders should not be in there in the first place. Trying to manage manually the paths of FieldTrip and Brainstorm can lead to bugs that are difficult to understand, even by the developers.

@rcassani rcassani marked this pull request as draft December 15, 2021 15:22
@rcassani rcassani force-pushed the paths-for-unix-like branch from a83fd09 to aa20f89 Compare December 15, 2021 17:08
@rcassani
Copy link
Author

@ftadel, thanks for the insight. The handling of the FT path is removed.
However a new trouble is found as there is dependency for FT functions in ft_plotting, and it's loaded by Brainstorm.

@rcassani rcassani closed this Dec 15, 2021
@ftadel
Copy link
Collaborator

ftadel commented Dec 16, 2021

However a new trouble is found as there is dependency for FT functions in ft_plotting, and it's loaded by Brainstorm.

Can you give some more details about this issue?

rcassani closed this 18 hours ago

Dead end?

@rcassani
Copy link
Author

rcassani commented Dec 16, 2021

Can you give some more details about this issue?

Sorry for the false alarm, it was my messy path

Dead end?

Not really, I think the FT path handling can be solved like this: 5ed7b77

@rcassani rcassani reopened this Dec 16, 2021
@rcassani rcassani changed the title Bugfix: backslash removed from path Check for required Matlab toolboxes Nov 16, 2023
@rcassani rcassani marked this pull request as ready for review November 16, 2023 15:42
@rcassani rcassani mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants