Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(50)Return interface instead of unexported struct #358

Open
wants to merge 1 commit into
base: sig-auth-acceptance
Choose a base branch
from
Open

(50)Return interface instead of unexported struct #358

wants to merge 1 commit into from

Conversation

ShazaAldawamneh
Copy link

this PR to resolve issue 50

kramaranya
kramaranya suggested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@kramaranya kramaranya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the issue was fixed, please address the feedback. It should be a super easy one line code change :)

@ibihim
Copy link
Collaborator

ibihim commented Feb 13, 2025

/lgtm

stlaz
stlaz requested changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@stlaz stlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s codebase is kind of torn on the discussion in this PR itself.

I'm leaning towards returning an interface because we need to make sure we implement it fully anyway.

@ibihim
Copy link
Collaborator

ibihim commented Feb 24, 2025

I'm leaning towards returning an interface because we need to make sure we implement it fully anyway.

Uf. This is actually a good reason. We need to be sure that it is an authorizer, so before we add a var _ authorizer.Authorizer = &staticAuthorizer{}, we could actually return an interface in the first place.

@stlaz
Copy link
Collaborator

stlaz commented Feb 24, 2025

I'd suggest implementing #351 (comment) and closing this PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibihim ibihim ibihim left review comments

@kramaranya kramaranya kramaranya requested changes

@stlaz stlaz stlaz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShazaAldawamneh @ibihim @stlaz @kramaranya