Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.16.1 fix #294

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

ibihim
Copy link
Collaborator

@ibihim ibihim commented May 7, 2024

What

Fix a regression for the removed flags.

Why

If the bool value flag was specified like --logtostderr, without the =true, it was treated like --logtostderr=true in v0.15.0.
In v0.16.0 and v0.17.0, --logtostderr without any value would treat the follow up flag as its value, which leads to a regression.

@liouk
Copy link

liouk commented May 7, 2024

/lgtm

@ibihim ibihim merged commit 3e5e2bd into brancz:release-0.16.0 May 7, 2024
7 checks passed
@ibihim ibihim deleted the release-0.16.1-fix branch May 7, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants