Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent panics on client-cert authenticated requests #132

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Prevent panics on client-cert authenticated requests #132

merged 1 commit into from
Jul 22, 2021

Commits on Jul 22, 2021

  1. Prevent panics on client-cert authenticated requests 

    Setting a nil-value typed object in the `DelegatingAuthenticatorConfig`
will cause the generic logic to still evaluate is as non-nil since
Golang does not consider `(*type)(nil)` as `nil` in `== nil` comparison
unless `type == nil`, too.

This leads to a setup of an x509 authenticator that attempts to call
`VerifyOptions` on a nil object.
    @stlaz @paulfantom
    stlaz authored and paulfantom committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    6c0e103 View commit details
    Browse the repository at this point in the history