add prometheus-adapter CRD #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
reviewed
Feb 22, 2021
| Port int `json:"port,omitempty"` | ||
| // Configuration of prometheus-adapter in the same form as in | ||
| // +optional | ||
| Config promadapter.MetricsDiscoveryConfig `json:"config,omitempty"` // TODO: requires https://github.com/kubernetes-sigs/prometheus-adapter/pull/372 |
There was a problem hiding this comment.
I was thinking about this earlier, and I wasn't sure how to do it, but this is brilliant that this works.
There was a problem hiding this comment.
There is a problem of including external APIs defined with yaml tags instead of json ones. It seems controller-gen fails to generate CRD when json tag is not defined. This problem can be seen here (but I think we can change it upstream) and for example in blackbox-exporter:
There was a problem hiding this comment.
More about blackbox thingy in #7
paulfantom
force-pushed
the
prometheus-adapter
branch
2 times, most recently
from
ddaea9a to
6017082
Compare
paulfantom
changed the title
|
kubernetes-sigs/prometheus-adapter#372 was merged so I rebased it to fix merge conflicts and now this is done. |
Signed-off-by: paulfantom <pawel@krupa.net.pl>
paulfantom
force-pushed
the
prometheus-adapter
branch
from
6017082 to
cad8964
Compare
|
Amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by an external factor. I'll drive upstream changes first and come back to this when those are ready.
Signed-off-by: paulfantom pawel@krupa.net.pl