Document another way to use with rust-analyzer #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bram209
reviewed
Jul 9, 2024
README.md
Outdated
| ### Setting up with unstable directory based rust-analyzer configuration | ||
| An alternative way to configure `rust-analyzer` to use `leptosfmt` is to use directory based `rust-analyzer` configuration. | ||
|
|
||
| To do this named `rust-analyzer.toml` to the root of your project with the content: |
There was a problem hiding this comment.
Suggested change
| To do this named `rust-analyzer.toml` to the root of your project with the content: | |
| To do this, create a file named `rust-analyzer.toml` in the root of your project with the following content: |
There was a problem hiding this comment.
or "add a file named ... to the root ..."
There was a problem hiding this comment.
I can't believe how i messed this up :D nicely spotted
README.md
Outdated
|
|
||
| This method of setting up rust-analyzer is editor agnostic to any editor that uses `rust-analyzer` for formatting rust code | ||
|
|
||
| > Note: This feature of `rust-analyzer` is currently unstable and no guarantees are made that this will continue to work across versions. |
There was a problem hiding this comment.
Maybe mention the minimum version required?
https://github.com/rust-lang/rust-analyzer/releases/tag/2024-06-10
Suggested change
| > Note: This feature of `rust-analyzer` is currently unstable and no guarantees are made that this will continue to work across versions. | |
| > Note: This feature of `rust-analyzer` is currently unstable and no guarantees are made that this will continue to work across versions. You have to use a recent version of `rust-analyzer` ([2024-06-10](https://github.com/rust-lang/rust-analyzer/releases/tag/2024-06-10) or newer). |
|
@bram209 I like the proposed changes, updated the pr with adjustments now! Thanks for the feedback! |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #126 by documenting the discussed alternative way to configure
rust-anlyzerto useleptosfmtto format code