Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v7] Update Venmo to Support Only Universal Links #1489

Merged
merged 12 commits into from
Dec 20, 2024
Merged

[v7] Update Venmo to Support Only Universal Links #1489

merged 12 commits into from
Dec 20, 2024

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • Remove BTAppContextSwitcher.sharedInstance.returnURLScheme
  • Remove BTVenmoClient(apiClient:) init in favor of universalLink init
  • Cleanup demo app
  • Remove logic around returnURLScheme in the Venmo flow since this is no longer needed
  • Remove no longer needed error case
  • Cleanup unit tests based on updated logic

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner December 19, 2024 14:45
richherrera
richherrera approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@richherrera richherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Demo/Application/Features/VenmoViewController.swift Outdated Show resolved Hide resolved
@jaxdesmarais jaxdesmarais merged commit 830a48f into v7 Dec 20, 2024
8 checks passed
@jaxdesmarais jaxdesmarais deleted the venmo-remove-url-scheme branch December 20, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmkesselj warmkesselj warmkesselj approved these changes

@richherrera richherrera richherrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @richherrera @warmkesselj