[v7] Remove cardAddChallenge
#1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
commented
Dec 16, 2024
| let uiType: BTThreeDSecureUIType | ||
| let v2UICustomization: BTThreeDSecureV2UICustomization? | ||
|
|
||
| var dfReferenceID: String? |
There was a problem hiding this comment.
This is the only property that should need to be a var according to our logic. Updated these and the unit tests with this change. Also confirmed in the demo app things are still appearing as expected.
jaxdesmarais
commented
Dec 16, 2024
| @@ -108,26 +106,6 @@ class BTThreeDSecureClient_Tests: XCTestCase { | |||
| waitForExpectations(timeout: 1) | |||
| } | |||
|
|
|||
| func testPerformThreeDSecureLookup_whenCardAddChallengeNotRequested_sendsCardAddFalse() { | |||
There was a problem hiding this comment.
This test was specific to this removed logic in the client:
} else if request._cardAddChallenge == .notRequested {
requestParameters["cardAdd"] = false
}
richherrera
approved these changes
Dec 17, 2024
Co-authored-by: Rich Herrera <ricardherrera@paypal.com>
# Conflicts: # Sources/BraintreeThreeDSecure/BTThreeDSecureRequest.swift
warmkesselj
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
cardAddChallengeandBTThreeDSecureCardAddChallengeChecklist
Authors