Add URLOpener protocol for mocking UIApplication.shared

[scannillo]

Summary of changes

• Move to protocol & extension to mock UIApplication.shared
  • This let's us remove the logic that lived in BTVenmoClient source code which only existed for mocking
• Update FakeApplication to conform to new protocol

References

http://swiftyjimmy.com/mock-uiapplication-swift/

Checklist

• Added a changelog entry

Authors

@scannillo

[jaxdesmarais]

Take it or leave it, but if we want to provide defaults like open in UIApplication we can provide it in a protocol extension to URLOpener:

public extension URLOpener {

    func open(_ url: URL, options: [UIApplication.OpenExternalURLOptionsKey: Any] = [:], completionHandler completion: ((Bool) -> Void)? = nil) {
        open(url, options: options, completionHandler: completion)
    }
}

Would allow us to update this and the call to open in performAppSwitch to:

application.open(appStoreURL) // openVenmoAppPageInAppStore
application.open(appSwitchURL) { success in // performAppSwitch

[scannillo]

Yeh this crossed my mind - but I thought the purpose of the protocol extension was confusing to read/deduce. I don't mind the passing of the empty dict and nil completion, but will defer to what folks think is more clear!

[jaxdesmarais]

I like the cleaner callsite but I 100% just think that's a personal preference. Lol. I am fine with either so will leave it up to you to decide!

[sshropshire]

🔥