Revert Xcode 15 Runner Image Change #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scannillo
reviewed
Oct 24, 2023
| - name: Run UI Tests | ||
| run: set -o pipefail && xcodebuild -workspace 'BraintreeDropIn.xcworkspace' -sdk 'iphonesimulator' -configuration 'Debug' -scheme 'UITests' -destination 'name=iPhone 15,platform=iOS Simulator' test | xcpretty | ||
| run: set -o pipefail && xcodebuild -workspace 'BraintreeDropIn.xcworkspace' -sdk 'iphonesimulator' -configuration 'Debug' -scheme 'UITests' -destination 'name=iPhone 14,OS=16.4,platform=iOS Simulator' test | xcpretty |
There was a problem hiding this comment.
The latest iOS version provided by Xcode is what this defaults to. Isn't 16.4 the latest the Xcode 14.3 offers? See https://xcodereleases.com/
There was a problem hiding this comment.
It seems like iOS 17 may be the default for the runner but you may be right, it's a bit unclear. Was looking at this issue: actions/runner-images#8023
There was a problem hiding this comment.
It does seem to have failed faster but not sure if that is accurate. We can also merge main into the 2 latest PRs to see if the Xcode 15 changes help there. 🤷
jaxdesmarais
changed the title
jaxdesmarais
changed the title
|
UI Tests are still expected to fail |
sarahkoop
approved these changes
Oct 25, 2023
scannillo
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
[ ] Added a changelog entryAuthors