Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup UI Tests #433

Merged
merged 13 commits into from
Nov 6, 2023
Merged

Cleanup UI Tests #433

merged 13 commits into from
Nov 6, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • Update UI test names
  • Remove tokenization step where not needed
  • Cleanup assertions
  • Remove redundant UI tests

Checklist

  • [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

scannillo and others added 7 commits October 23, 2023 11:53
@scannillo @jaxdesmarais
Use enum instead of bool for various auth types used in Demo & UI Tes…
0c72974 
…ts; mirror braintree_ios UserDefaults setup

Signed-off-by: Jax DesMarais-Leder <jdesmarais@paypal.com>
@scannillo @jaxdesmarais
Remove BraintreeDemoUseTokenizationKey from Root.plist and associated…
8845c36 
… DemoSetting bool property

Signed-off-by: Jax DesMarais-Leder <jdesmarais@paypal.com>
@jaxdesmarais
add hardcoded client token
c0844f9
@jaxdesmarais
add UITestHardcodedClientTokenWithCustomerID and UITestHardcodedClien…
c58acb4 
…tTokenWithoutCustomerID since UITests expect different values
@jaxdesmarais
fetch client token for 3DS test
7cc67ea
@scannillo
Add additional Demo authType for hard-coded ClientToken w/ CVV valida…
0920ca0 
…tion enabled
@jaxdesmarais @scannillo
remove tokenization when not needed; cleanup test names; cleanup asse…
d38e697 
…rtions; remove redundant tests

Co-authored-by: Sammy Cannillo <scannillo@paypal.com>
@jaxdesmarais jaxdesmarais requested a review from a team as a code owner October 24, 2023 16:57
scannillo
scannillo approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@scannillo scannillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this, even if tests are still failing this PR can only help

Base automatically changed from use-hardcoded-client-id-tests to main November 3, 2023 21:46
@jaxdesmarais
Merge branch 'main' into cleanup-ui-tests
c6446a3 
# Conflicts:
#	Demo/Application/DemoAppDelegate.swift
#	Demo/Application/DemoContainerViewController.swift
#	Demo/Application/Settings/DemoSettings.swift
@jaxdesmarais
update edit tests
963c5c6
@jaxdesmarais jaxdesmarais merged commit 679100e into main Nov 6, 2023
3 of 4 checks passed
@jaxdesmarais jaxdesmarais deleted the cleanup-ui-tests branch November 6, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@scannillo scannillo scannillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @scannillo @sshropshire