Restructure Demo - Use CocoaPods #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am messing around with how development with this structure will feel, so far the ObjC <--> Swift interop is tricky. We might prefer a "Carthage" style setup for our demo instead. |
|
Closing in favor of using a Carthage-style setup for our project structure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to start converting the DropIn source code file-by-file from Objective-C to Swift. Starting this work revealed a limitation of the structure of our Demo app and local xcodeproject.
See error:
Currently our Demo uses SPM to pull in a local version of the DropIn source code. It is a known limitation that SPM does not support mixed language dependencies. So, with this setup we will not be able to run our Demo app as we convert file-by-file to Swift.
Changes
This PR restructures our Demo app to pull in a local version of DropIn via CocoaPods, instead of SPM.
Podfilefor the Demo appBraintreeDropIn.podspecin order to build the DropInChecklist
Added a changelog entryAuthors
@scannillo