Resolve deviceData nil on BTDropInResult
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
approved these changes
Aug 9, 2022
sshropshire
reviewed
Aug 9, 2022
Comment on lines
+46
to
+51
| if (PayPalDataCollectorClass != NSClassFromString(PayPalDataCollectorClassString)) { | ||
| _deviceData = [PayPalDataCollectorClass collectPayPalDeviceData]; | ||
| return self; | ||
| } | ||
| // Otherwise we should use `PPDataCollector` to collect device data | ||
| _deviceData = [PPDataCollector collectPayPalDeviceData]; |
There was a problem hiding this comment.
This is wild. So the test was injecting a definition for PayPalDataCollectorClass? So glad we're moving to Swift lol.
There was a problem hiding this comment.
Yeah, the test was setting a class, but the actual implementation never was - so tests were passing with the mock class being injected and the live code was returning nil for the past year 😢 Swift will certainly help us catch these cases sooner!
|
Tower was acting wild and closed/deleted this branch temporarily, so ignore that noise/chaos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
deviceDatawas always nil onBTDropInResult- this was due to how we were mocking the data collector but previously never actually calling the data collector to get device data as expectedChecklist
Authors