Remove masking on decoding attention

brainsqueeze · Dec 31, 2019 · 213b436 · 213b436
1 parent 898445a
commit 213b436
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/setup.py b/setup.py
@@ -11,7 +11,7 @@
 
 setup(
     name="text2vec",
-    version="0.1",
+    version="0.1.1",
     description="Building blocks for text vectorization and embedding",
     author="Dave Hollander",
     author_url="https://github.com/brainsqueeze",

diff --git a/text2vec/models/transformer.py b/text2vec/models/transformer.py
@@ -62,7 +62,7 @@ def __call__(self, x_enc, enc_mask, x_dec, dec_mask, context, attention, embeddi
             x_dec = self.h_dropout(mha([x_dec] * 3, mask_future=True, training=training), training=training) + x_dec
             x_dec = self.layer_norm(x_dec)
 
-            cross_context = attention(encoded=x_enc * enc_mask, decoded=x_dec * dec_mask)
+            cross_context = attention(encoded=x_enc, decoded=x_dec)
             x_dec = self.h_dropout(self.projection(x_dec, projection_vector=cross_context), training=training) + x_dec
 
             x_dec = self.layer_norm(x_dec)