New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save Lua scripts as class vars; register them once #283

Merged

brainix merged 2 commits into master from lua-script-registration

Dec 4, 2020

Owner

brainix commented Dec 4, 2020

Previously, we were saving Lua scripts as instance variables and
re-registering them every time we instantiated a Redlock or NextId.

I got this pattern from here:
https://github.com/andymccurdy/redis-py/blob/1a41cfd95a53a95b078084d8627be6b6fba3bb71/redis/lock.py#L140-L149

brainix added 2 commits

December 3, 2020 22:45


          Save Lua scripts as class vars; register them once

ef36104

Previously, we were saving Lua scripts as instance variables and
re-registering them every time we instantiated a `Redlock` or `NextId`.

I got this pattern from here:
https://github.com/andymccurdy/redis-py/blob/1a41cfd95a53a95b078084d8627be6b6fba3bb71/redis/lock.py#L140-L149


          Bump version number

841f543

Owner Author

brainix commented Dec 4, 2020

🐟

brainix merged commit fb29409 into master

brainix deleted the lua-script-registration branch

December 4, 2020 07:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet