Simplify HyperLogLog.update() #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were including `self.key` in `other_hll_keys` to be merged in. However, this is unnecessary, as we're saving the new HyperLogLog back to `self.key`. And according to the official documentation: > The computed merged HyperLogLog is set to the destination variable, > which is created if does not exist (defaulting to an empty HyperLogLog). > If the destination variable exists, it is treated as one of the source > sets and its cardinality will be included in the cardinality of the > computed HyperLogLog. For more info: https://redis.io/commands/pfmerge
|
🐟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were including
self.keyinother_hll_keysto bemerged in.
However, this is unnecessary, as we're saving the new HyperLogLog back
to
self.key. And according to the official documentation:For more info:
https://redis.io/commands/pfmerge