Improve Makefile #256
Merged
Improve Makefile #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, `$ make upgrade` upgraded _only_ the top-level requirements specified in `requirements-to-freeze.txt`, not _all_ of the requirements specified in `requirements.txt`. Further, there was no Makefile target to rebuild a clean `venv` and generate a clean `requirements.txt` (useful for example when removing a requirement that recursively pulled in other requirements). 1. Specify a `requirements` target to rebuild the `venv` 2. Make the `upgrade` target upgrade _all_ requirements 3. Upgrade all requirements 4. Add the Distributed Computing Trove classifier
I didn't realize that `--verbose` means I'm going to avalanche vomit on top of your head.
|
🐟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR,
$ make upgradeupgraded only the top-levelrequirements specified in
requirements-to-freeze.txt, not all of therequirements specified in
requirements.txt. Further, there was noMakefile target to rebuild a clean
venvand generate a cleanrequirements.txt(useful for example when removing a requirement thatrecursively pulled in other requirements).
requirementstarget to rebuild thevenvupgradetarget upgrade all requirements