Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModuleNotFoundError: No module named 'typing_extensions' #299

Closed
skieffer opened this issue Dec 26, 2020 · 3 comments · Fixed by #301
Closed

ModuleNotFoundError: No module named 'typing_extensions' #299

skieffer opened this issue Dec 26, 2020 · 3 comments · Fixed by #301
Assignees
@brainix
Labels
bug dependencies Pull requests that update a dependency file

Comments

@skieffer
Copy link

Hi, this looks like a nice library, but I'm having a little trouble getting started. After

pip install pottery

I'm finding that import pottery triggers a

ModuleNotFoundError: No module named 'typing_extensions'

Maybe typing_extensions needs to be included in the install_requires in setup.py? (I have not used setuptools much, so that is just my guess.)
@brainix brainix self-assigned this Dec 27, 2020
@brainix brainix added bug dependencies Pull requests that update a dependency file labels Dec 27, 2020
@brainix
Copy link
Owner

brainix commented Dec 27, 2020

Hi, @skieffer!

I apologize for the inconvenience, and thanks for the bug report. I'll try to reproduce this myself today or tomorrow, and I'll update this issue based on what I find.

Thanks again,
Raj

brainix added a commit that referenced this issue Dec 27, 2020
@brainix
Include typing_extensions in install_requires
430ea8f 
Without making Pottery depend on `typing_extensions`, Pottery fails to
install correctly.

Bug first reported here: #299

I used this as an example: https://github.com/tensorflow/tensorflow/blob/4a8d9cf405e5be8cf250f7fa141f2013f395b5fe/tensorflow/tools/pip_package/setup.py#L89

Thanks, @skieffer, for suggesting this fix.
@brainix brainix mentioned this issue Dec 27, 2020
Merged
brainix added a commit that referenced this issue Dec 27, 2020
@brainix
Include typing_extensions in install_requires
5cea4b2 
Without making Pottery depend on `typing_extensions`, Pottery fails to
install correctly.

Bug first reported here: #299

I used this as an example: https://github.com/tensorflow/tensorflow/blob/4a8d9cf405e5be8cf250f7fa141f2013f395b5fe/tensorflow/tools/pip_package/setup.py#L89

Thanks, @skieffer, for suggesting this fix.
@brainix
Copy link
Owner

brainix commented Dec 27, 2020 •
edited
Loading

Hi, @skieffer.

I think you have two options here:

  1. If you want to use your currently installed version of Pottery (or any version <= 1.0.8), you can issue pip install typing_extensions and it should work.
  2. I’ve implemented your suggested bug fix and released Pottery 1.0.9, so you can upgrade your Pottery installation to 1.0.9.

Please try either of these approaches and let me know if it works out for you? Then I'll close this issue.

Thanks,
Raj

@skieffer
Copy link
Author

skieffer commented Dec 27, 2020 •
edited
Loading

Great! I used option 1 while I was waiting, and now I've upgraded to v1.0.9, which also works. Thank you!

EDIT: I should add that I manually uninstalled typing_extensions before upgrading to Pottery 1.0.9, so this does serve as an actual test.

@brainix brainix closed this as completed Dec 28, 2020
@brainix brainix linked a pull request Dec 28, 2020 that will close this issue
Include typing_extensions in install_requires #301
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brainix brainix

Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include typing_extensions in install_requires brainix/pottery
2 participants
@brainix @skieffer