Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Responsive circles #17

Merged
merged 5 commits into from
Dec 19, 2020
Merged

[Feature] Responsive circles #17

merged 5 commits into from
Dec 19, 2020

Conversation

anibalsolon
Copy link
Member

@anibalsolon anibalsolon commented Dec 19, 2020

The cute circle patterns in the header did not scale well for smaller devices, such as smartphones. To properly scale, the number of circles must adapt according to the resolution. In this PR, I propose the following progression:

image

The number of circles is rounded to the closest odd number so that there are two circles of the same size in the center. #aesthetics

The controlling variables for the linear progression and other aspects of the pattern are exposed at the beginning of the code.

Hopefully closes #12 !

@r03ert0 r03ert0 merged commit c4066be into master Dec 19, 2020
@r03ert0
Copy link
Contributor

r03ert0 commented Dec 19, 2020

Thank you for fixing this!!

@anibalsolon anibalsolon mentioned this pull request Dec 19, 2020
@katjaq
Copy link
Member

katjaq commented Dec 19, 2020

Thank you dear @anibalsolon ! That's fantastic!! :) 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale svg banner correctly based on window size
3 participants