Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BySpace and ByCoordinate traits have been refactored and exported #209

Merged
merged 11 commits into from
Dec 8, 2023

Conversation

brainandforce
Copy link
Owner

Notably, the DataSpace trait function has been internally deprecated and replaced with BySpace. There are also some new functions for checking that traits of different objects are compatible.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c0b3203) 59.82% compared to head (4f9b1ee) 60.07%.

Files Patch % Lines
src/data/grids.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   59.82%   60.07%   +0.25%     
==========================================
  Files          23       23              
  Lines        1558     1563       +5     
==========================================
+ Hits          932      939       +7     
+ Misses        626      624       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brainandforce brainandforce merged commit 5441714 into main Dec 8, 2023
7 checks passed
@brainandforce brainandforce deleted the refactor/traits branch December 8, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant