Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vasp energies #190

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix/vasp energies #190

merged 2 commits into from
Oct 31, 2023

Conversation

xamberl
Copy link
Collaborator

@xamberl xamberl commented Oct 31, 2023

VASP-related functions get_fermi, readDOSCAR, and readPROCAR returned energies in eV. Now they should return these in Ha.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (44c873b) 58.60% compared to head (2dd7053) 58.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files          19       19           
  Lines        1406     1406           
=======================================
  Hits          824      824           
  Misses        582      582           
Files Coverage Δ
src/software/vasp.jl 52.26% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@brainandforce brainandforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about the test coverage at the moment: I'll handle that issue later.

@brainandforce brainandforce merged commit fad30b5 into main Oct 31, 2023
4 of 5 checks passed
@brainandforce brainandforce deleted the fix/vasp-energies branch October 31, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants