New: Support automatic scraping periodically #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baruchiro
reviewed
Nov 2, 2024
packages/preload/src/index.ts
Outdated
Comment on lines
9
to
10
| // Clear the interval that scrapes periodically | ||
| await stopPeriodicScraping(); |
There was a problem hiding this comment.
I'm not sure about this, wrote you on Whatsapp
|
שיניתי את המימוש שיראה את השעה של הריצה ההבאה. |
brafdlog
commented
Nov 9, 2024
| @@ -67,10 +68,11 @@ export const registerHandlers = () => { | |||
| ipcMain.on('scrape', async (event: IpcMainEvent) => { | |||
| const config = await getConfig(); | |||
| const eventSubscriber = new BudgetTrackingEventEmitter(); | |||
| scrapeAndUpdateOutputVendors(config, eventSubscriber); | |||
There was a problem hiding this comment.
@baruchiro we had a bug here, listening to events was set up only after running scrape, and scraping was without await, so there was a race condition on whether or not the first event set would be caught by the onAny handler or not.
baruchiro
approved these changes
Nov 10, 2024
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
הוספתי אפשרות בהגדרות להגיד שרוצים שירוץ אוטומטית כל כמה שעות
זה נראה ככה:
כשלוחצים על הפעל זה מאתחל את הטיימר של ההרצה האוטומטית.