Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: nodejs version to 16 #513

Merged
merged 4 commits into from
Dec 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,23 @@
"build": {
"dockerfile": "Dockerfile",
// Update 'VARIANT' to pick a Node version: 10, 12, 14
"args": { "VARIANT": "14" }
"args": {
"VARIANT": "16"
}
},

// Set *default* container specific settings.json values on container create.
"settings": {
"settings": {
"terminal.integrated.shell.linux": "/bin/bash"
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": [
"dbaeumer.vscode-eslint",
"octref.vetur"
],

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "cat /gnome-keyring-fix.sh >> ~/.bashrc",

// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
"remoteUser": "node"
}
}
23 changes: 19 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 14.x
# https://github.com/nodejs/node-gyp/issues/2869
- name: Use Python 3.11
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Use Node.js 16.x
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 16.x
cache: 'yarn'
cache-dependency-path: 'yarn.lock'
- run: yarn --network-timeout 100000
Expand All @@ -31,14 +36,19 @@ jobs:

strategy:
matrix:
node-version: [14.x]
node-version: [16.x]
os:
- windows-latest
- ubuntu-latest
- macos-latest

steps:
- uses: actions/checkout@v4
# https://github.com/nodejs/node-gyp/issues/2869
- name: Use Python 3.11
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand Down Expand Up @@ -78,10 +88,15 @@ jobs:

steps:
- uses: actions/checkout@v4
# https://github.com/nodejs/node-gyp/issues/2869
- name: Use Python 3.11
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 16.x
cache: 'yarn'
cache-dependency-path: 'yarn.lock'
- run: yarn --network-timeout 100000
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/semantic-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ jobs:

steps:
- uses: actions/checkout@v4
# https://github.com/nodejs/node-gyp/issues/2869
- name: Use Python 3.11
uses: actions/setup-python@v4
with:
python-version: '3.11'
- run: yarn --network-timeout 100000
- uses: cycjimmy/semantic-release-action@8f6ceb9d5aae5578b1dcda6af00008235204e7fa
id: semantic
Expand All @@ -46,10 +51,15 @@ jobs:

steps:
- uses: actions/checkout@v4
# https://github.com/nodejs/node-gyp/issues/2869
- name: Use Python 3.11
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 16.x
cache: 'yarn'
cache-dependency-path: 'yarn.lock'
- name: Install Snapcraft
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14
v16
Loading