Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: electron version from v9 to v13 #378

Merged
merged 4 commits into from
Oct 15, 2022
Merged

Upgrade: electron version from v9 to v13 #378

merged 4 commits into from
Oct 15, 2022

Conversation

baruchiro
Copy link
Collaborator

@baruchiro baruchiro commented Oct 7, 2022 •
edited
Loading

Followed by BREAKING CHANGES on electronjs.

Upgrade spectron.

Hopefully will affect #276.

@brafdlog
Copy link
Owner

Great work baruch!
I am already using these changes to be able develop on mac (previously had to work on a windows VM)

@baruchiro
Copy link
Collaborator Author

@brafdlog good luck, I forced push right now 🤷🏼

Do you have an M1 processor? Because I hope it will also solve this problem.

@brafdlog
Copy link
Owner

I have an M1 mac and had to do some additional changes. Still working that, but I did get it working. Although it does require downloading chromium manually

@baruchiro baruchiro changed the title Upgrade: electron version Upgrade: electron version from v9 to v13 Oct 15, 2022
@baruchiro baruchiro marked this pull request as ready for review October 15, 2022 17:35
@baruchiro baruchiro requested a review from brafdlog as a code owner October 15, 2022 17:35
@brafdlog brafdlog merged commit 20e859b into master Oct 15, 2022
@brafdlog brafdlog deleted the electron branch October 15, 2022 18:28
baruchiro added a commit that referenced this pull request Oct 16, 2022
@baruchiro
Upgrade: electron version from v9 to v13 (#378)
3895983
github-actions bot pushed a commit that referenced this pull request Oct 16, 2022
@semantic-release-bot
chore(release): 0.2.0 [skip ci]
26a2f56 
# [0.2.0](v0.1.2...v0.2.0) (2022-10-16)

### Upgrade

* electron version from v9 to v13 (#378) ([3895983](3895983)), closes [#378](#378)
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced Oct 18, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brafdlog brafdlog brafdlog approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baruchiro @brafdlog