Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated URL to get high quality Pokémon images #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BhanuVikram
Copy link

Hi Brad,

My name is Bhanu Vikram. I am one of your students in the 50 Projects In 50 Days course. I noticed an issue in line number 50 of this file: https://github.com/bradtraversy/50projects50days/blob/master/pokedex/script.js. The Pokémon images were missing or low quality. I have fixed the issue with a different URL.

Because of Prettier, you will see numerous changes, but the only change I have made is on line number 50. I have not made any other changes to your code.

I have changed this link:

<img src="https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/${pokemon.id}.png"" alt="${name}">

to:

<img src="https://assets.pokemon.com/assets/cms2/img/pokedex/full/${id}.png" alt="${name}">

This is my first ever contribution, and I hope that you will accept this PR.

Kind regards,
Bhanu

Bhanu Vikram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant