Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visitorName lost when window closed #11

Closed
tvigil opened this issue Mar 14, 2016 · 3 comments
Closed

visitorName lost when window closed #11

tvigil opened this issue Mar 14, 2016 · 3 comments
Assignees
Labels

Comments

@tvigil
Copy link

tvigil commented Mar 14, 2016

I am using the SLjs.Button method of launching the chat window, and specifying a user name in the config with the "visitorName" parameter. I found that when closing the window, the user identity specified by the visitorName parameter is lost. When clicking the trigger button to open the window again, it prompts for a new user name.
Awesome project!! Thanks! :)

@tvigil
Copy link
Author

tvigil commented Mar 14, 2016

Also, if you accidentally click on the triggering button twice, that also has the effect of dropping the visitorName.

@tvigil
Copy link
Author

tvigil commented Mar 14, 2016

Also, I noticed that when I comment on issues here, I get rude messages from Brad on Slack. Very strange. XD

@bradmb bradmb added the bug label Mar 14, 2016
@bradmb bradmb self-assigned this Mar 14, 2016
bradmb added a commit that referenced this issue Mar 14, 2016
Caused visitor name to be lost after disposing of data due to window
closing
bradmb added a commit that referenced this issue Mar 14, 2016
@bradmb
Copy link
Owner

bradmb commented Mar 14, 2016

This issue has been fixed. A NuGet package update has been deployed and the releases page contains the latest .zip file.

@bradmb bradmb closed this as completed Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants