Monitor as a Singleton? #20
-
|
Brad I want to have a single instance of the Monitor class feeding events to n number of other classes running in there own threads. I'm considering wrapping the Monitor in a Singleton class. So,
TIA Kevin |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
|
@ruffk that's a great catch -- it really should be a singleton and not transient. I really can't think of a usecase for needing multiple instances of the Monitor class itself. You should be able to instantiate it as a singleton, inject it into any classes/threads, and have the various consumers all just hook into the event listeners. |
Beta Was this translation helpful? Give feedback.
-
|
Have added issue #21 to track this. |
Beta Was this translation helpful? Give feedback.
-
|
One more thought regarding this. Since it will be a singleton, it would be nice to have an IsStarted property to check. You might want to use that internally too to make sure someone doesn't call StartCaptureAsync while it's already running (to at least ignore the request). |
Beta Was this translation helpful? Give feedback.
@ruffk that's a great catch -- it really should be a singleton and not transient. I really can't think of a usecase for needing multiple instances of the Monitor class itself. You should be able to instantiate it as a singleton, inject it into any classes/threads, and have the various consumers all just hook into the event listeners.