cmd/errtrace: Fix toolexec with go run main.go
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantv
force-pushed
the
prashant/run-files
branch
2 times, most recently
from
e4a6133 to
024fb28
Compare
When compiling files passed as command line arguments, go uses a special package name, "command-line-arguments". Similarly for tests, it uses "command-line-arguments.test". Rather than hardcoding these special package names, let's update the stdlib detection to: * Rule out any package with "." (as no stdlib packages contain periods) * Look for "-std" in the arguments passed to compile Update the toolexec tests to compile with files passed directly on the command line, and verify both "go run" and "go build".
prashantv
force-pushed
the
prashant/run-files
branch
from
024fb28 to
7000935
Compare
abhinav
approved these changes
Feb 18, 2024
cmd/errtrace/toolexec.go
Outdated
| @@ -10,6 +10,7 @@ import ( | |||
| "path/filepath" | |||
| "runtime" | |||
| "runtime/debug" | |||
| "slices" | |||
There was a problem hiding this comment.
We currently have 1.20 in the supported list.
Options: drop the 1.20, or don't use slices.Contains.
Your call. I don't have a preference.
There was a problem hiding this comment.
Kept 1.20 since it was simple enough to build a pre-1.21 slices contains.
abhinav
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling files passed as command line arguments, go uses a special
package name, "command-line-arguments". Similarly for tests, it uses
"command-line-arguments.test".
Rather than hardcoding these special package names, let's update the
stdlib detection to:
Update the toolexec tests to compile with files passed directly on the
command line, and verify both "go run" and "go build".