Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable logging filter (Sourcery refactored) #50

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Apr 2, 2022

Pull Request #49 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the logging-filter branch, then run:

git fetch origin sourcery/logging-filter
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from br3ndonland April 2, 2022 19:43
return not any(match in message for match in self.filters)
return all(match not in message for match in self.filters)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function LogFilter.filter refactored with the following changes:

@vercel
Copy link

vercel bot commented Apr 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/br3ndonland/inboard/C43FjqfogPwX8819YkkFK9Tz2X4m
✅ Preview: https://inboard-git-sourcery-logging-filter-br3ndonland.vercel.app

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Apr 2, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 3.33 ⭐ 3.33 ⭐ 0.00
Method Length 59.43 ⭐ 59.29 ⭐ -0.14 👍
Working memory 7.57 🙂 7.57 🙂 0.00
Quality 75.13% 75.15% 0.02% 👍
Other metrics Before After Change
Lines 140 140 0
Changed files Quality Before Quality After Quality Change
inboard/logging_conf.py 75.13% ⭐ 75.15% ⭐ 0.02% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
inboard/logging_conf.py LogFilter.set_filters 2 ⭐ 32 ⭐ 10 😞 77.42% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #50 (b2fb3c7) into logging-filter (32792cd) will not change coverage.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           logging-filter       #50   +/-   ##
================================================
  Coverage          100.00%   100.00%           
================================================
  Files                  10        10           
  Lines                 281       281           
================================================
  Hits                  281       281           
Flag Coverage Δ
unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
inboard/logging_conf.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32792cd...b2fb3c7. Read the comment docs.

@br3ndonland br3ndonland merged commit fba2fd2 into logging-filter Apr 2, 2022
@br3ndonland br3ndonland deleted the sourcery/logging-filter branch April 2, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant