Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing TableView Height when Keyboard Appears Ruins Keyboard Transparency in iOS 7 #12

Closed
fabb opened this issue May 12, 2014 · 5 comments
Milestone

Comments

@fabb
Copy link

fabb commented May 12, 2014

In iOS 7 the keyboard is semi-transparent. BPForms resizes the tableview when the keyboard appears. This makes the Keyboard look transparent until it completely appeared, then the background color jump-animates to the view's background color.

ios simulator screen shot 12 05 2014 08 47 42
ios simulator screen shot 12 05 2014 08 47 43

Wouldn't it be possible to just set the tableview's contentInset and scrollIndicatorInsets instead of resizing the scroll view?

bpoplauschi added a commit that referenced this issue May 16, 2014
… Transparency in iOS 7 #12. Thanks to @fabb for the original implementation.
@bpoplauschi
Copy link
Owner

@fabb Fixed by 468f970. I changed a bit the pull request you created, since it had some issues.

@fabb
Copy link
Author

fabb commented May 16, 2014

Thanks for fixing. Is there a reason you prefer UIKeyboardDidShowNotification? If you'd use UIKeyboardWillShowNotification as in my pull request, the text field would scroll into place while the keyboard animation takes place.

@bpoplauschi
Copy link
Owner

I remember some cases while doing the initial dev (on iOS6 I think) where the keyboard height value was wrong in willShow. Or was it in landscape? Anyway, I recall something being wrong with that value when using willShow.

@bpoplauschi bpoplauschi added this to the 2.0.1 milestone May 16, 2014
@fabb
Copy link
Author

fabb commented May 16, 2014

We use willShow in our current app (iOS 6+7) and it works fine. The only issue we have is that a bottom toolbar is sometimes taken account for twice. But I guess that would be the same with didShow.

@bpoplauschi
Copy link
Owner

@fabb I've retested (iOS 6 and 7, landscape and portrait) and I cannot replicate that issue. I have switched to name:UIKeyboardWillShowNotification in 82aa73a and will keep an eye on this one. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants