Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restore focus on the canvas when pop up is closed #22

Closed
wants to merge 2 commits into from

Conversation

jarekdanielak
Copy link

Proposed Changes

Related to camunda/camunda-modeler#4620
Related to https://github.com/bpmn-io/internal-docs/issues/1081

Utilize new Canvas#restoreFocus API to restore focus on the canvas after the pop up closes.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not needed, as the chooser is a popup editor (core diagram concern). Popups should already integrate natively with the new diagram focus behavior.

@jarekdanielak
Copy link
Author

Correct. Works out of the box with new diagram-js. Closing this one.

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants