Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagram js 4 #402

Merged
merged 8 commits into from
Jul 15, 2019
Merged

Diagram js 4 #402

merged 8 commits into from
Jul 15, 2019

Conversation

nikku
Copy link
Member

@nikku nikku commented Jul 15, 2019

Closes #400

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 15, 2019
@nikku nikku requested a review from philippfromme July 15, 2019 06:42
@nikku nikku marked this pull request as ready for review July 15, 2019 06:42
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 15, 2019
philippfromme
philippfromme approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 💎

@merge-me merge-me bot merged commit 78f7036 into develop Jul 15, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the diagram-js-4 branch July 15, 2019 09:08
@philippfromme philippfromme mentioned this pull request Jul 15, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to diagram-js@4
2 participants
@nikku @philippfromme