Handle keyboard input without search active

[nikku]

Depends on #706, #709, #708.

---

Closes #701

[smbea]

I found a bug in hovering the header elements:

Without search: works as expected

Screen.Recording.2022-11-23.at.10.50.33.mov

With search: hover doesn't work

Screen.Recording.2022-11-23.at.10.49.26.mov

I seems this was caused by the changed in #706:

- if (!entries.includes(selectedEntry) && !selectedEntry) {
+ if (!entries.includes(selectedEntry) || !selectedEntry) {

[nikku]

@smbea Without additional context could you user test the latest changes on this branch. Does it feel intuitive for you and fix #710 (comment)?

[smbea]

@nikku it fixes the issue. But I'm a little torn because the first state shown when the menu is opened (first entry selected) is different from when the mouse enters and leaves the menu (nothing is selected). Personally: I would expect either always having something selected or only having something selected if explicitly selected (don't select by default). But I don't know if that's just me 😅

[nikku]

#710 (comment)

Thanks for the feedback. We could ensure that "automatic selection" only happens if there is actual keyboard filtering happening. Why we have it in the first place: To support a streamlined keyboard selection flow.

[smbea]

@nikku I think that makes sense. I also understand why we did it, but the difference in those situations just felt a bit off

[nikku]

Getting rid of the initial keyboard focus feels odd, too. For users to understand that they can navigate using the keyboard they need an initial visual indication.

Let's leave it like this; I'll try to see if I can ramp up the test coverage.

---

For comparison menu:

And similar menu in Camunda Desktop Modeler:

[smbea]

@nikku true. If we already have something similar and no doesn't bother anyone, then I agree we keep it for now at least.

I didn't find any other issues so I'd say we are good to go

[barmac]

It works great. I wouldn't change anything interaction-wise.

[nikku]

Following up on the proposed improvements here: #711.

This branch can be reviewed independently.