Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select All Elements after Creating Elements #392

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Select All Elements after Creating Elements #392

merged 2 commits into from
Aug 9, 2019

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Aug 8, 2019 •
edited by philippfromme
Loading

Adds autoSelect hint for specifying elements that should be selected after create. Setting autoSelect to false will not select any elements.

Related to bpmn-io/bpmn-js#1152

Aug-08-2019 10-44-00

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 8, 2019
@pinussilvestrus pinussilvestrus mentioned this pull request Aug 8, 2019
Merged
@pinussilvestrus pinussilvestrus changed the title Select all elements after selection Select all elements after creating elemenrs Aug 8, 2019
philippfromme
philippfromme reviewed Aug 8, 2019
View reviewed changes
lib/features/create/Create.js Outdated Show resolved Hide resolved
lib/features/selection/SelectionBehavior.js Outdated Show resolved Hide resolved
@philippfromme philippfromme changed the title Select all elements after creating elemenrs Select all elements after creating elements Aug 8, 2019
@philippfromme philippfromme force-pushed the 1152-select-all-elements branch from 342b682 to 67a7c16 Compare August 9, 2019 11:29
@philippfromme
feat(selection-behavior): add autoSelect hint
29c0447 
* autoSelect === Array<djs.model.Base> selects elements
* autoSelect === false selects no elements

Related to bpmn-io/bpmn-js#1152
@philippfromme philippfromme force-pushed the 1152-select-all-elements branch from 67a7c16 to 29c0447 Compare August 9, 2019 11:30
@philippfromme philippfromme changed the title Select all elements after creating elements Select All Elements after Creating Elements Aug 9, 2019
@philippfromme philippfromme requested review from barmac and nikku August 9, 2019 12:21
barmac
barmac approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merge-me merge-me bot merged commit 46863a5 into develop Aug 9, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the 1152-select-all-elements branch August 9, 2019 12:40
@nikku nikku mentioned this pull request Aug 9, 2019
Closed
1 task
@nikku nikku added this to the M30 milestone Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme left review comments

@barmac barmac barmac approved these changes

@nikku nikku Awaiting requested review from nikku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M30
Development

Successfully merging this pull request may close these issues.
4 participants
@pinussilvestrus @philippfromme @barmac @nikku