Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing attributes to the renderer #578

Closed
marstamm opened this issue Oct 25, 2021 · 0 comments · Fixed by #579
Closed

Allow passing attributes to the renderer #578

marstamm opened this issue Oct 25, 2021 · 0 comments · Fixed by #579
Assignees
@marstamm
Labels
enhancement New feature or request

Comments

@marstamm
Copy link
Contributor

marstamm commented Oct 25, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

This allows us to create render "Ghost Elements" (c.f. bpmn-io/bpmn-js#1443) with the default render stack.

Describe the solution you'd like

Add a attrs as a 3rd argument to drawShape and drawConnection calls.

Describe alternatives you've considered

none

Additional context

bpmn-io/bpmn-js#1443,
bpmn-io/bpmn-js#1506 (comment)
@marstamm marstamm added ready Ready to be worked on enhancement New feature or request labels Oct 25, 2021
@marstamm marstamm self-assigned this Oct 25, 2021
marstamm added a commit that referenced this issue Oct 25, 2021
@marstamm
feat(renderer): allow passing of attrs
dbff57c 
closes #578
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Oct 25, 2021
marstamm added a commit that referenced this issue Oct 25, 2021
@marstamm
feat(renderer): allow passing of attrs
f081af1 
closes #578
@marstamm marstamm mentioned this issue Oct 25, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 25, 2021
marstamm added a commit that referenced this issue Oct 25, 2021
@marstamm
feat(renderer): allow passing of attrs
c290d6a 
closes #578
@fake-join fake-join bot closed this as completed in #579 Oct 25, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 25, 2021
fake-join bot pushed a commit that referenced this issue Oct 25, 2021
@marstamm @fake-join
feat(renderer): allow passing of attrs
c3f6c70 
closes #578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(renderer): allow passing of attrs bpmn-io/diagram-js
1 participant
@marstamm