Improve ID handling #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for multiple digram instances with minimaps on the same page
nikku
reviewed
May 30, 2024
| @@ -28,9 +29,12 @@ import { | |||
|
|
|||
| import { getVisual } from 'diagram-js/lib/util/GraphicsUtil'; | |||
|
|
|||
| import IdGenerator from 'diagram-js/lib/util/IdGenerator'; | |||
There was a problem hiding this comment.
We must declare this as an external dependency in rollup config.
There was a problem hiding this comment.
added a regex to ensure this will not happen again: 4d19666
nikku
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diagram-js-minimapinstances on the same pagerelated to bpmn-io/bpmn-js#2179