-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ad-hoc sub process via replace menu #2276
Conversation
I marked |
Yes. What starts with |
var isTargetExpanded = target.isExpanded === true; | ||
|
||
return isDifferentType(target, target) && (!isTargetSubProcess || isTargetExpanded); | ||
// Collapsed subprocess cannot be replaced with itself or expanded subprocess of different type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is useful for our future selves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, and the solution works great from the user perspective. I wonder why we have not implemented it this way in the first place :D
Related to camunda/camunda-modeler#4801
Proposed Changes
Make ad-hoc subprocess available as a replace menu entry.
Screen.Recording.2025-01-23.at.14.15.05.mov
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}