Do not translate technical errors #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors are non-user facing. You shall be able to find them in public knowledge bases _as is_.
These are technical errors that shall be searchable in public knowledge bases _as is_.
nikku
force-pushed
the
937-error-messages
branch
from
7708bf8 to
9f67018
Compare
nikku
changed the title
bpmn-io-tasks
bot
added
needs review
barmac
approved these changes
Apr 23, 2024
ChaominRuan
reviewed
Apr 27, 2024
| @@ -83,7 +80,7 @@ export default function BpmnTreeWalker(handler, translate) { | |||
| // avoid multiple rendering of elements | |||
| if (gfx) { | |||
| throw new Error( | |||
| translate('already rendered {element}', { element: elementToString(element) }) | |||
| 'already rendered ${ elementToString(element) }' | |||
There was a problem hiding this comment.
tagged template is missing, has been modified in this pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a change in how we handle technical errors: These are no longer translated, both during modeling and during import.
Due to the nature of technical errors it makes little sense to localize them. If I need help on how to fix a particular technical issue, then I want to search for these errors as is.
Closes https://github.com/bpmn-io/internal-docs/issues/937
Related to #2137