Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bpmn-moddle@9 #2114

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Update to bpmn-moddle@9 #2114

merged 2 commits into from
Oct 6, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 7, 2024

This uses bpmn-moddle@9, a release that cleans up some existing legacy.

The library, as well as upstream now expose true ES modules, and still expose CJS modules for use. The library also requires Node@18 (Node@16 is out of maintainance since 2023).

For safety reasons I'd regard this as a breaking change that we want to batch with other breaking changes (if any).

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 7, 2024
@nikku nikku added the backlog Queued in backlog label Mar 14, 2024 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Mar 14, 2024
@nikku nikku marked this pull request as ready for review October 2, 2024 05:57
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed backlog Queued in backlog labels Oct 2, 2024
@nikku nikku force-pushed the bump-bpmn-moddle branch from 792452a to 617d658 Compare October 2, 2024 06:04
nikku added 2 commits October 2, 2024 08:06
Upstream changes:

* Requires Node >= 18
* Adds `exports` configuration (requires modern bundlers)
Not compatible with NodeNext module resolution.
@nikku nikku force-pushed the bump-bpmn-moddle branch from 617d658 to 247929b Compare October 2, 2024 06:06
@nikku nikku merged commit 88cf98b into develop Oct 6, 2024
12 checks passed
@nikku nikku deleted the bump-bpmn-moddle branch October 6, 2024 16:32
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants