Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Add type declarations to Modeling.js #1881

Closed
wants to merge 2 commits into from
Closed

wip: Add type declarations to Modeling.js #1881

wants to merge 2 commits into from

Conversation

miyuesc
Copy link
Contributor

@miyuesc miyuesc commented Apr 4, 2023

  1. Add type declarations to Modeling.js
  2. The options parameter in the saveXML method is optional

@nikku
Copy link
Member

nikku commented Apr 4, 2023

@miyuesc We're currently in the process of generating type definitions for bpmn-js, cf. #1866. Does your PR work on top of these changes?

@nikku
Copy link
Member

nikku commented Apr 4, 2023

Note that with #1866 our approach changed to automatic type generation from JavaScript files. So rather than creating .d.ts files you'd fix the type definitions in the JS sources.

nikku added a commit that referenced this pull request Apr 4, 2023
nikku added a commit that referenced this pull request Apr 4, 2023
@nikku nikku added the in progress Currently worked on label Apr 5, 2023 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Apr 5, 2023
@miyuesc
Copy link
Contributor Author

miyuesc commented Apr 6, 2023

I'm sorry, I didn't notice it was used this way before.

@miyuesc miyuesc closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants