Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get module context #1835

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Get module context #1835

merged 2 commits into from
Feb 6, 2023

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 6, 2023

Implements what we discussed in camunda/camunda-bpmn-js#236 (comment) and following.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 6, 2023
@nikku nikku requested review from philippfromme and smbea February 6, 2023 13:07
smbea
smbea approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense

@nikku nikku merged commit 84d53de into develop Feb 6, 2023
@nikku nikku deleted the get-module-context branch February 6, 2023 16:26
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbea smbea smbea approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @smbea