Fix TypeUtil#isDifferentType type util
#1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current ReplaceOptions.TRANSACTION / ReplaceOptions.EVENT_SUB_PROCESS mask a bug that prevents us from properly detecting equality of popup menu entries. This commit fixes the bug and removes the workaround in the replace options.
nikku
force-pushed
the
fix-popup-menu-type-util
branch
from
cc24ea1 to
0f977c0
Compare
smbea
reviewed
Dec 5, 2022
Comment on lines
-34
to
+36
| businessObject.triggeredByEvent === target.triggeredByEvent | ||
|
|
||
| // coherse to <false> | ||
| !!target.triggeredByEvent === !!businessObject.triggeredByEvent |
There was a problem hiding this comment.
Not fully understanding what this achieves. Could you clarify a bit more?
There was a problem hiding this comment.
I updated the issue with additional context.
There was a problem hiding this comment.
Thanks for the additional context
6 tasks
smbea
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the
TypeUtil#isDifferentTypeissue reported through camunda/camunda-bpmn-js#213 (comment).The underlying issue is that
TypeUtil#isDifferentTypewould not detect that the transaction entry matches a transaction element. This is due totriggerByEvent=falseon thebpmn:Transaction, andtriggeredByEvent=undefinedon the menu entry. This leads tofalse === undefinedwhich isfalsewhen it should betrue.The reason this did not surface yet is that we had distinct entries for transactions and event-subprocesses so that no filtering was ever needed.
We rely on the utility to properly work in connectors land, working around #1786.